linux-kernel - Re: [PATCH 1/2] dt-bindings: power: qcom,rpmhpd: Add Generic RPMh PD indexes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 21 Jul 2023 20:05:28 -0700
From:   Bjorn Andersson <andersson@...nel.org>
To:     Rohit Agarwal <quic_rohiagar@...cinc.com>
Cc:     Pavan Kondeti <quic_pkondeti@...cinc.com>, agross@...nel.org,
        konrad.dybcio@...aro.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: power: qcom,rpmhpd: Add Generic RPMh PD
 indexes

On Fri, Jul 21, 2023 at 06:47:42PM +0530, Rohit Agarwal wrote:
> On 7/21/2023 11:14 AM, Pavan Kondeti wrote:
> > On Wed, Jul 19, 2023 at 10:52:41AM +0530, Rohit Agarwal wrote:
> > > diff --git a/include/dt-bindings/power/qcom,rpmhpd.h b/include/dt-bindings/power/qcom,rpmhpd.h
[..]
> > > +
> > > +#endif
> > > -- 
> > I see the PD performance levels (RPMH_REGULATOR_LEVEL_xxx) are still
> > coming from qcom-rpmpd.h. Which means Socs with RPMh also need to
> > include the older header for these definitions along with this newly
> > created header. something to improve for the clarity sake?
> Agreed. I think we can move these to the new header so that the new SoC with
> RPMH can completely
> move to rpmhpd.h.

Sounds very reasonable, please do that in a follow up patch.
I'm picking this as is.

Thanks,
Bjorn