linux-kernel - Re: [PATCH v3 1/2] dt-bindings: display: add bindings for pcd8544 displays

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <66fc3434-8cc4-3316-ffda-2ffa08cce0f6@linaro.org>
Date:   Sun, 23 Jul 2023 11:52:35 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Viktar Simanenka <viteosen@...il.com>
Cc:     David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: display: add bindings for pcd8544
 displays

On 21/07/2023 14:25, Viktar Simanenka wrote:
> On Fri, Jul 21, 2023 at 11:42 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@...aro.org> wrote:
>>
>> On 20/07/2023 14:40, Viktar Simanenka wrote:
>>> +allOf:
>>> +  - $ref: panel/panel-common.yaml#
>>
>> This is not a panel, is it?
> 
> I can't clearly tell the difference between LCD display and panel.
> I've added panel-common because of 'backlight' and 'reset-gpios'
> properties. I've looked at 'sitronix,st7735r.yaml',
> 'ilitek,ili9486.yaml' as examples. SPI controlled LCD displays, but in

Probably your device is not a panel (datasheet says: LCD controller),
thus it should not reference panel-common.


> color.
> In fact 'reset-gpios' is already in my yaml. I might just add the
> 'backlight' property explicitly and remove this dependency. Should I?

Best regards,
Krzysztof