linux-kernel - Re: [PATCH v2 1/1] net: gro: fix misuse of CB in udp socket lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9c0a3c64-2bcb-9b82-1805-a29cb7b7e617@nvidia.com>
Date:   Sun, 23 Jul 2023 15:07:24 +0300
From:   Gal Pressman <gal@...dia.com>
To:     Richard Gobert <richardbgobert@...il.com>, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        willemdebruijn.kernel@...il.com, dsahern@...nel.org,
        tom@...bertland.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Nimrod Oren <noren@...dia.com>
Subject: Re: [PATCH v2 1/1] net: gro: fix misuse of CB in udp socket lookup

On 20/07/2023 19:26, Richard Gobert wrote:
> This patch fixes a misuse of IP{6}CB(skb) in GRO, while calling to
> `udp6_lib_lookup2` when handling udp tunnels. `udp6_lib_lookup2` fetch the
> device from CB. The fix changes it to fetch the device from `skb->dev`.
> l3mdev case requires special attention since it has a master and a slave
> device.
> 
> Fixes: a6024562ffd7 ("udp: Add GRO functions to UDP socket")
> Reported-by: Gal Pressman <gal@...dia.com>
> Signed-off-by: Richard Gobert <richardbgobert@...il.com>

Thanks Richard!
Tested-by: Nimrod Oren <noren@...dia.com>