[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAJF2gTS7-N=KkDeeja_v1hvydgBPVCv6X6zZW8hj37Hntz56Sg@mail.gmail.com>
Date: Sun, 23 Jul 2023 22:50:41 +0800
From: Guo Ren <guoren@...nel.org>
To: Drew Fustini <dfustini@...libre.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
Randy Dunlap <rdunlap@...radead.org>,
Colin Ian King <colin.i.king@...il.com>,
Diederik de Haas <didi.debian@...ow.org>,
Ian Rogers <irogers@...gle.com>, SeongJae Park <sj@...nel.org>,
Luca Ceresoli <luca.ceresoli@...tlin.com>,
linux-kernel@...r.kernel.org, Conor Dooley <conor@...nel.org>,
Jisheng Zhang <jszhang@...nel.org>
Subject: Re: [PATCH] scripts/spelling.txt: remove 'thead' as a typo
Good catch, thank you very much.
Acked-by: Guo Ren <guoren@...nel.org>
On Sun, Jul 23, 2023 at 9:04 AM Drew Fustini <dfustini@...libre.com> wrote:
>
> T-Head is a vendor of processor core IP, and they have recently
> introduced the RISC-V TH1520 SoC. Remove 'thead' as a typo of 'thread'
> to avoid checkpatch incorrectly warning that 'thead' is typo in patches
> that add support for T-Head designs in the kernel.
>
> Cc: Conor Dooley <conor@...nel.org>
> Cc: Guo Ren <guoren@...nel.org>
> Cc: Jisheng Zhang <jszhang@...nel.org>
> Link: https://www.t-head.cn/
> Signed-off-by: Drew Fustini <dfustini@...libre.com>
> ---
> scripts/spelling.txt | 1 -
> 1 file changed, 1 deletion(-)
>
> For example, checkpatch prints the following warnings for 89b0186ab532
> ("dt-bindings: riscv: Add T-HEAD TH1520 board compatibles"):
>
> $ ./scripts/checkpatch.pl --strict -g 89b0186ab532
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> new file mode 100644
>
> WARNING: 'thead' may be misspelled - perhaps 'thread'?
> +$id: http://devicetree.org/schemas/riscv/thead.yaml#
> ^^^^^
>
> WARNING: 'thead' may be misspelled - perhaps 'thread'?
> + - const: thead,th1520
> ^^^^^
> total: 0 errors, 3 warnings, 0 checks, 29 lines checked
>
> The 'thead' typo false positive adds noise to automation like the
> linux-riscv patchwork bot:
> https://patchwork.kernel.org/project/linux-riscv/patch/20230722-upstream-beaglev-ahead-dts-v1-2-ccda511357f4@baylibre.com/
>
> diff --git a/scripts/spelling.txt b/scripts/spelling.txt
> index fc7ba95e86a0..855c4863124b 100644
> --- a/scripts/spelling.txt
> +++ b/scripts/spelling.txt
> @@ -1541,7 +1541,6 @@ temeprature||temperature
> temorary||temporary
> temproarily||temporarily
> temperture||temperature
> -thead||thread
> theads||threads
> therfore||therefore
> thier||their
> --
> 2.34.1
>
--
Best Regards
Guo Ren
Powered by blists - more mailing lists