linux-kernel - Re: [PATCH V3 2/2] pinctrl: Add driver support for Amlogic C3 SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 23 Jul 2023 21:21:50 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Huqiang Qin <huqiang.qin@...ogic.com>
Cc:     robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        conor+dt@...nel.org, neil.armstrong@...aro.org,
        khilman@...libre.com, jbrunet@...libre.com,
        martin.blumenstingl@...glemail.com, brgl@...ev.pl, andy@...nel.org,
        linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V3 2/2] pinctrl: Add driver support for Amlogic C3 SoCs

On Mon, Jul 17, 2023 at 9:25 AM Huqiang Qin <huqiang.qin@...ogic.com> wrote:

> > Andy had more comments about the header inclusion. Please
> > include all used headers directly as requested, I think it's a good
> > idea and avoids confusing compile problems.
>
> Yes, this is a good idea, but when many files must include the same batch
> of header files (seems to have become a kind of template), it seems like
> a good choice for us to put them all in pinctrl-meson.h (actually been doing
> this a long time ago).

OK I'd say that is up to the taste of the driver maintainer so it's OK.

Yours,
Linus Walleij