linux-kernel - Re: [PATCH v1 1/1] driver core: Move dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230723203035.wmdskibs2lvofnju@intel.intel>
Date:   Sun, 23 Jul 2023 22:30:35 +0200
From:   Andi Shyti <andi.shyti@...nel.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/1] driver core: Move dev_err_probe() to where it
 belogs

Hi Andi,

On Fri, Jul 21, 2023 at 04:13:09PM +0300, Andy Shevchenko wrote:
> dev_err_probe() belongs to the printing API, hence
> move the definition from device.h to dev_printk.h.
> 
> There is no change to the callers at all, since:
> 1) implementation is located in the same core.c;
> 2) dev_printk.h is guaranteed to be included by device.h.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

yes! I think that's right!

Reviewed-by: Andi Shyti <andi.shyti@...nel.org> 

Andi