linux-kernel - Re: [patch 47/58] x86/apic: Remove pointless arguments from [native_]eoi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZL2tjHz0hvfEyrZc@liuwe-devbox-debian-v2>
Date:   Sun, 23 Jul 2023 22:45:32 +0000
From:   Wei Liu <wei.liu@...nel.org>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     LKML <linux-kernel@...r.kernel.org>, x86@...nel.org,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Andrew Cooper <andrew.cooper3@...rix.com>,
        Tom Lendacky <thomas.lendacky@....com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Wei Liu <wei.liu@...nel.org>,
        Arjan van de Ven <arjan@...ux.intel.com>,
        Juergen Gross <jgross@...e.com>
Subject: Re: [patch 47/58] x86/apic: Remove pointless arguments from
 [native_]eoi_write()

On Tue, Jul 18, 2023 at 01:15:47AM +0200, Thomas Gleixner wrote:
> Every callsite hands in the same constants which is a pointless exercise
> and cannot be optimized by the compiler due to the indirect calls.
> 
> Use the constants in the eoi() callbacks and remove the arguments.
> 
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> ---
>  arch/x86/hyperv/hv_apic.c             |    6 +++---

The change looks trivially correct.

In conjunction with the function name change:

Reviewed-by: Wei Liu <wei.liu@...nel.org>