linux-kernel - Re: [PATCH] vmbus_testing: fix wrong python syntax for integer value comparison

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZL21k2GWKgZldIq4@liuwe-devbox-debian-v2>
Date:   Sun, 23 Jul 2023 23:19:47 +0000
From:   Wei Liu <wei.liu@...nel.org>
To:     Ani Sinha <anisinha@...hat.com>
Cc:     "K. Y. Srinivasan" <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Wei Liu <wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>,
        linux-hyperv@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vmbus_testing: fix wrong python syntax for integer value
 comparison

On Mon, Jul 17, 2023 at 01:13:25PM +0530, Ani Sinha wrote:
> 
> 
> > On 05-Jul-2023, at 7:14 PM, Ani Sinha <anisinha@...hat.com> wrote:
> > 
> > It is incorrect in python to compare integer values using the "is" keyword.
> > The "is" keyword in python is used to compare references to two objects,
> > not their values. Newer version of python3 (version 3.8) throws a warning
> > when such incorrect comparison is made. For value comparison, "==" should
> > be used.
> > 
> > Fix this in the code and suppress the following warning:
> > 
> > /usr/sbin/vmbus_testing:167: SyntaxWarning: "is" with a literal. Did you mean "=="?
> 
> Ping …
> 

Applied to hyperv-fixes. Thanks.