[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230723101416.398589b3@jic23-huawei>
Date: Sun, 23 Jul 2023 10:14:16 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
Lars-Peter Clausen <lars@...afoo.de>,
Nuno Sa <nuno.sa@...log.com>
Subject: Re: [PATCH v2 4/8] iio: core: Use min() instead of min_t() to make
code more robust
On Fri, 21 Jul 2023 20:00:18 +0300
Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:
> min() has strict type checking and preferred over min_t() for
> unsigned types to avoid overflow. Here it's unclear why min_t()
> was chosen since both variables are of the same type. In any
> case update to use min().
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Reviewed-by: Nuno Sa <nuno.sa@...log.com>
Applied to the togreg branch of iio.git and pushed out as testing
for 0-day to give it a quick sanity check.
Thanks,
Jonathan
> ---
> drivers/iio/industrialio-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
> index 6e28c2a3d223..78cc67efa490 100644
> --- a/drivers/iio/industrialio-core.c
> +++ b/drivers/iio/industrialio-core.c
> @@ -389,7 +389,7 @@ static ssize_t iio_debugfs_write_reg(struct file *file,
> char buf[80];
> int ret;
>
> - count = min_t(size_t, count, (sizeof(buf)-1));
> + count = min(count, sizeof(buf) - 1);
> if (copy_from_user(buf, userbuf, count))
> return -EFAULT;
>
Powered by blists - more mailing lists