linux-kernel - Re: [PATCH v3] cdx: add support for bus mastering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2023072447-slaw-spiffy-51ba@gregkh>
Date:   Mon, 24 Jul 2023 14:28:34 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Nipun Gupta <nipun.gupta@....com>
Cc:     linux-kernel@...r.kernel.org, git@....com,
        pieter.jansen-van-vuuren@....com, nikhil.agarwal@....com,
        michal.simek@....com, abhijit.gangurde@....com
Subject: Re: [PATCH v3] cdx: add support for bus mastering

On Mon, Jul 24, 2023 at 05:34:33PM +0530, Nipun Gupta wrote:
> Introduce cdx_set_master() and cdx_clear_master() APIs to support
> enable and disable of bus mastering. Drivers need to use these APIs to
> enable/disable DMAs from the CDX devices.
> 
> Signed-off-by: Nipun Gupta <nipun.gupta@....com>
> Reviewed-by: Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@....com>
> ---

You are adding apis here that no one is actually using, making it pretty
impossible to see if they are being used properly, or if they are even
needed at all.

Please submit this as part of a patch series that uses the apis,
otherwise there's no need for anyone to accept this patch.

thanks,

greg k-h