[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <DU2PR04MB8630E70773BD645687022DEE9502A@DU2PR04MB8630.eurprd04.prod.outlook.com>
Date: Mon, 24 Jul 2023 12:57:46 +0000
From: Pankaj Gupta <pankaj.gupta@....com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
"shawnguo@...nel.org" <shawnguo@...nel.org>,
"s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
"kernel@...gutronix.de" <kernel@...gutronix.de>,
"clin@...e.com" <clin@...e.com>,
"conor+dt@...nel.org" <conor+dt@...nel.org>,
"pierre.gondois@....com" <pierre.gondois@....com>,
Jacky Bai <ping.bai@....com>,
Clark Wang <xiaoning.wang@....com>,
Wei Fang <wei.fang@....com>, Peng Fan <peng.fan@....com>,
Bough Chen <haibo.chen@....com>,
"festevam@...il.com" <festevam@...il.com>,
dl-linux-imx <linux-imx@....com>,
"davem@...emloft.net" <davem@...emloft.net>,
"robh+dt@...nel.org" <robh+dt@...nel.org>,
"krzysztof.kozlowski+dt@...aro.org"
<krzysztof.kozlowski+dt@...aro.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Gaurav Jain <gaurav.jain@....com>,
"alexander.stein@...tq-group.com" <alexander.stein@...tq-group.com>,
Sahil Malhotra <sahil.malhotra@....com>,
Aisheng Dong <aisheng.dong@....com>,
Varun Sethi <V.Sethi@....com>
Subject: RE: [EXT] Re: [PATCH v4 4/7] arm64: dts: imx93-11x11-evk: added nxp
secure enclave fw
> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Sent: Thursday, July 13, 2023 12:38 AM
> To: Pankaj Gupta <pankaj.gupta@....com>; shawnguo@...nel.org;
> s.hauer@...gutronix.de; kernel@...gutronix.de; clin@...e.com;
> conor+dt@...nel.org; pierre.gondois@....com; Jacky Bai
> <ping.bai@....com>; Clark Wang <xiaoning.wang@....com>; Wei Fang
> <wei.fang@....com>; Peng Fan <peng.fan@....com>; Bough Chen
> <haibo.chen@....com>; festevam@...il.com; dl-linux-imx <linux-
> imx@....com>; davem@...emloft.net; robh+dt@...nel.org;
> krzysztof.kozlowski+dt@...aro.org; linux-arm-kernel@...ts.infradead.org;
> devicetree@...r.kernel.org; linux-kernel@...r.kernel.org; Gaurav Jain
> <gaurav.jain@....com>; alexander.stein@...tq-group.com; Sahil Malhotra
> <sahil.malhotra@....com>; Aisheng Dong <aisheng.dong@....com>; Varun
> Sethi <V.Sethi@....com>
> Subject: [EXT] Re: [PATCH v4 4/7] arm64: dts: imx93-11x11-evk: added nxp
> secure enclave fw
>
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
>
>
> On 12/07/2023 14:12, Pankaj Gupta wrote:
> > Added support for NXP secure enclave called EdgeLock Enclave firmware
> > (se-fw) for imx93-11x11-evk.
> >
> > Signed-off-by: Pankaj Gupta <pankaj.gupta@....com>
> > ---
> > arch/arm64/boot/dts/freescale/imx93.dtsi | 11 ++++++++++-
> > 1 file changed, 10 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi
> > b/arch/arm64/boot/dts/freescale/imx93.dtsi
> > index 8643612ace8c..2b0f901d2709 100644
> > --- a/arch/arm64/boot/dts/freescale/imx93.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
> > @@ -1,6 +1,6 @@
> > // SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > /*
> > - * Copyright 2022 NXP
> > + * Copyright 2022-2023 NXP
> > */
> >
> > #include <dt-bindings/clock/imx93-clock.h> @@ -863,5 +863,14 @@
> > ddr-pmu@...00dc0 {
> > reg = <0x4e300dc0 0x200>;
> > interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
> > };
> > +
> > + ele_fw: se-fw {
> > + compatible = "fsl,imx93-ele";
> > + mboxes = <&s4muap 0 0 &s4muap 1 0>;
>
> This should be two entries.
>
[Accepted] Will correct in the V5.
> > + mbox-names = "tx", "rx";
> > + fsl,mu-did = <3>;
> > + fsl,mu-id = <2>;
>
> Drop both. Since you put it into the DTSI, it means it is compatible specific.
>
[Accepted] Will correct it in V5. Also remove these entries from .yaml file.
> > + status = "okay";
>
> Drop.
[Accepted] will drop this in V5.
>
>
>
> Best regards,
> Krzysztof
Powered by blists - more mailing lists