linux-kernel - Re: [PATCH] misc_cgroup: Fix the obsolete comment around 'struct misc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7690e7b2-6e7f-6ff1-5249-72f497f82f7e@oracle.com>
Date:   Mon, 24 Jul 2023 19:14:05 +0530
From:   Kamalesh Babulal <kamalesh.babulal@...cle.com>
To:     Kai Huang <kai.huang@...el.com>, cgroups@...r.kernel.org
Cc:     tj@...nel.org, hannes@...xchg.org, lizefan.x@...edance.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] misc_cgroup: Fix the obsolete comment around 'struct
 misc_res'



On 7/24/23 17:24, Kai Huang wrote:
> The comment of the 'failed' member of 'struct misc_res' is obsolete
> since commit b03357528fd9 ("misc_cgroup: remove error log to avoid log
> flood"), which removed the 'failed' member from the structure.  Remove
> the obsolete comment.
> 
> Also add the missing comment for the 'events' field, which should come
> with commit f279294b3293 ("misc_cgroup: introduce misc.events to count
> failures") where the 'events' member was added.

This has been fixed by:
https://lore.kernel.org/lkml/20230718090834.1829191-1-kamalesh.babulal@oracle.com/

> 
> Signed-off-by: Kai Huang <kai.huang@...el.com>
> ---
>  include/linux/misc_cgroup.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/misc_cgroup.h b/include/linux/misc_cgroup.h
> index c238207d1615..41aa213a1125 100644
> --- a/include/linux/misc_cgroup.h
> +++ b/include/linux/misc_cgroup.h
> @@ -31,7 +31,7 @@ struct misc_cg;
>   * struct misc_res: Per cgroup per misc type resource
>   * @max: Maximum limit on the resource.
>   * @usage: Current usage of the resource.
> - * @failed: True if charged failed for the resource in a cgroup.
> + * @events: Charge failure event counter of the resource.
>   */
>  struct misc_res {
>  	unsigned long max;
> 
> base-commit: 3f01e9fed8454dcd89727016c3e5b2fbb8f8e50c

-- 
Thanks,
Kamalesh