linux-kernel - Re: [PATCH 1/1] PCI: qcom: Add early fixup to set the max payload size for IPQ9574

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b9424d44-82bf-8863-a269-ab68fde232e7@quicinc.com>
Date:   Mon, 24 Jul 2023 19:21:49 +0530
From:   Praveenkumar I <quic_ipkumar@...cinc.com>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>, <mani@...nel.org>,
        <agross@...nel.org>, <andersson@...nel.org>,
        <lpieralisi@...nel.org>, <kw@...ux.com>, <robh@...nel.org>,
        <bhelgaas@...gle.com>, <linux-pci@...r.kernel.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC:     <quic_varada@...cinc.com>, <quic_devipriy@...cinc.com>
Subject: Re: [PATCH 1/1] PCI: qcom: Add early fixup to set the max payload
 size for IPQ9574


On 7/24/2023 6:23 PM, Konrad Dybcio wrote:
> On 24.07.2023 14:47, Praveenkumar I wrote:
>> Set 256 bytes as payload size for IPQ9574 via early fixup. This allows
>> PCIe RC to use the max payload size when a capable link partner is
>> connected.
>>
>> Signed-off-by: Praveenkumar I <quic_ipkumar@...cinc.com>
>> ---
> [...]
>
>> +static void qcom_fixup_mps_256(struct pci_dev *dev)
>> +{
>> +	pcie_set_mps(dev, 256);
> Looks like setting "dev->pcie_mpss = 1" here would make the PCIe generic
> code take care of this.
Yes, but that is not helping as the generic code pci_configure_mps() has 
a check for,
/         if (!bridge || !pci_is_pcie(bridge))/
/            return;/
/Here it is returning and mps is not set to new 256 bytes./
>
> Konrad
--
Thanks,
Praveenkumar