[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20230724143152.GA3430423-robh@kernel.org>
Date: Mon, 24 Jul 2023 08:31:52 -0600
From: Rob Herring <robh@...nel.org>
To: Luca Ceresoli <luca.ceresoli@...tlin.com>
Cc: Neil Armstrong <neil.armstrong@...aro.org>,
Sam Ravnborg <sam@...nborg.org>,
David Airlie <airlied@...il.com>,
Daniel Vetter <daniel@...ll.ch>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org,
Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
Paul Kocialkowski <paul.kocialkowski@...tlin.com>
Subject: Re: [PATCH 2/3] dt-bindings: display: panel: Add panels based on
ILITEK ILI9806E
On Thu, Jul 20, 2023 at 03:52:38PM +0200, Luca Ceresoli wrote:
> Hello Rob,
>
> thanks for reviewing.
>
> On Wed, 19 Jul 2023 13:02:54 -0600
> Rob Herring <robh@...nel.org> wrote:
>
> > On Wed, Jul 19, 2023 at 05:21:46PM +0200, Luca Ceresoli wrote:
> > > Add bindings for LCD panels based on the ILITEK ILI9806E RGB controller
> > > connected over SPI and the "ShenZhen New Display Co NDS040480800-V3"
> > > 480x800 panel based on it.
> > >
> > > Signed-off-by: Luca Ceresoli <luca.ceresoli@...tlin.com>
> > > ---
> > > .../display/panel/ilitek,ili9806e.yaml | 69 +++++++++++++++++++
> > > MAINTAINERS | 6 ++
> > > 2 files changed, 75 insertions(+)
> > > create mode 100644 Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml
> > >
> > > diff --git a/Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml b/Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml
> > > new file mode 100644
> > > index 000000000000..42abc6923065
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml
> > > @@ -0,0 +1,69 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/display/panel/ilitek,ili9806e.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Ilitek ILI9806E display panels
> > > +
> > > +maintainers:
> > > + - Luca Ceresoli <luca.ceresoli@...tlin.com>
> > > +
> > > +description:
> > > + This binding is for display panels using an Ilitek ILI9806E controller in
> > > + SPI mode.
> > > +
> > > +allOf:
> > > + - $ref: panel-common.yaml#
> >
> > A SPI device should reference spi-peripheral-props.yaml as well.
> >
> > > +
> > > +properties:
> > > + compatible:
> > > + items:
> > > + - enum:
> > > + # ShenZhen New Display Co 3.97" 480x800 RGB a-SI TFT LCD
> > > + - newdisplay,nds040480800-v3
> > > + - const: ilitek,ili9806e
> > > +
> > > + reg: true
> >
> > maxItems: 1
> >
> > > + spi-max-frequency: true
> > > + reset-gpios: true
> > > + backlight: true
> > > + port: true
> >
> > Drop all these and ...
> >
> > > +
> > > +required:
> > > + - compatible
> > > + - reg
> > > + - port
> > > +
> > > +additionalProperties: false
> >
> > ... use "unevaluatedProperties" instead.
> >
> > > +
> > > +examples:
> > > + - |
> > > + #include <dt-bindings/gpio/gpio.h>
> > > +
> > > + backlight: backlight {
> > > + compatible = "gpio-backlight";
> > > + gpios = <&gpio 22 GPIO_ACTIVE_HIGH>;
> > > + };
> >
> > The exact backlight is outside the scope of this binding and should be
> > dropped from the example.
>
> As this comes from copy-pasting from the bindings yaml for another
> panel, would it be useful if I send a patch to remove it?
Yes.
Rob
Powered by blists - more mailing lists