linux-kernel - Re: [PATCH v1 1/1] Revert "um: Use swap() to make code cleaner"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZL6LYvUpuRtwmWXZ@smile.fi.intel.com>
Date:   Mon, 24 Jul 2023 17:32:02 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     linux-um@...ts.infradead.org, linux-kernel@...r.kernel.org
Cc:     Richard Weinberger <richard@....at>,
        Anton Ivanov <anton.ivanov@...bridgegreys.com>,
        Johannes Berg <johannes@...solutions.net>,
        Rasmus Villemoes <linux@...musvillemoes.dk>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Herve Codina <herve.codina@...tlin.com>,
        "Jason A. Donenfeld" <Jason@...c4.com>,
        Yang Guang <yang.guang5@....com.cn>
Subject: Re: [PATCH v1 1/1] Revert "um: Use swap() to make code cleaner"

On Mon, Jul 24, 2023 at 05:23:07PM +0300, Andy Shevchenko wrote:
> This reverts commit 9b0da3f22307af693be80f5d3a89dc4c7f360a85.
> 
> The sigio.h is clearly user space code which is handled by

Should be .c

> arch/um/scripts/Makefile.rules (see USER_OBJS rule).
> 
> The above mentioned commit simply broke this agreement,
> we may not use Linux kernel internal headers in them without
> thorough thinking.
> 
> Hence, revert the wrong commit.

Missing Reported-by

> Closes: https://lore.kernel.org/oe-kbuild-all/202307212304.cH79zJp1-lkp@intel.com/

I have just sent a v2: https://lore.kernel.org/r/20230724143131.30090-1-andriy.shevchenko@linux.intel.com.

-- 
With Best Regards,
Andy Shevchenko