[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZL6bvQkBUsFErpXd@hovoldconsulting.com>
Date: Mon, 24 Jul 2023 17:41:49 +0200
From: Johan Hovold <johan@...nel.org>
To: Krishna Kurapati PSSNV <quic_kriskura@...cinc.com>
Cc: Thinh Nguyen <Thinh.Nguyen@...opsys.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Philipp Zabel <p.zabel@...gutronix.de>,
Andy Gross <agross@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konrad.dybcio@...aro.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Felipe Balbi <balbi@...nel.org>,
Wesley Cheng <quic_wcheng@...cinc.com>,
linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
quic_pkondeti@...cinc.com, quic_ppratap@...cinc.com,
quic_jackp@...cinc.com, quic_harshq@...cinc.com,
ahalaney@...hat.com, quic_shazhuss@...cinc.com
Subject: Re: [PATCH v9 03/10] usb: dwc3: core: Access XHCI address space
temporarily to read port info
[ Please remember to trim your replies. ]
On Sun, Jul 23, 2023 at 08:29:47PM +0530, Krishna Kurapati PSSNV wrote:
> On 6/27/2023 5:15 PM, Johan Hovold wrote:
> > On Wed, Jun 21, 2023 at 10:06:21AM +0530, Krishna Kurapati wrote:
> >> +#define XHCI_EXT_PORT_MAJOR(x) (((x) >> 24) & 0xff)
> >> +#define XHCI_EXT_PORT_MINOR(x) (((x) >> 16) & 0xff)
> >> +#define XHCI_EXT_PORT_COUNT(x) (((x) >> 8) & 0xff)
> >
> > Again, don't copy defines from xhci.
> >
> > Looks like these should be moved to the xhci-ext-caps.h header along
> > with struct xhci_protocol_caps.
>
> Moving the defines would be sufficient right ? Just wanted to know if
> there is any reason you are suggesting to move the structure as well so
> that I can update commit text accordingly.
The defines are used for parsing the members of struct
xhci_protocol_caps and they belong together even if no driver has
apparently ever used the structure.
Johan
Powered by blists - more mailing lists