linux-kernel - Re: [PATCH v1 1/2] arm64: dts: ti: k3-am62: Add MCU MCAN nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b48858f4-2904-fddf-fe9e-61100ba1a122@ti.com>
Date:   Mon, 24 Jul 2023 11:25:07 -0500
From:   Judith Mendez <jm@...com>
To:     Francesco Dolcini <francesco@...cini.it>
CC:     Nishanth Menon <nm@...com>, Vignesh Raghavendra <vigneshr@...com>,
        Tero Kristo <kristo@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Francesco Dolcini <francesco.dolcini@...adex.com>
Subject: Re: [PATCH v1 1/2] arm64: dts: ti: k3-am62: Add MCU MCAN nodes

Hi Francesco,

On 7/24/23 11:22 AM, Francesco Dolcini wrote:
> Hello Judith,
> 
> On Mon, Jul 24, 2023 at 11:06:24AM -0500, Judith Mendez wrote:
>> On 7/24/23 8:36 AM, Francesco Dolcini wrote:
>>> From: Judith Mendez <jm@...com>
>>>
>>> On AM62x there are no hardware interrupts routed to A53 GIC
>>> interrupt controller for MCU MCAN IPs, so MCU MCAN nodes were
>>> omitted from MCU dtsi.
>>>
>>> Timer polling was introduced in commits [1][2] so now add MCU MCAN nodes
>>> to the MCU dtsi for the Cortex A53.
>>>
>>> [1] b382380c0d2d ("can: m_can: Add hrtimer to generate software interrupt")
>>> [2] bb410c03b999 ("dt-bindings: net: can: Remove interrupt properties for MCAN")
>>>
>>> Signed-off-by: Judith Mendez <jm@...com>
>>> [fd: fixed labels to match datasheet numbering, revised commit message,
>>>        fixed reg/reg-names order]
>>> Signed-off-by: Francesco Dolcini <francesco.dolcini@...adex.com>
>>> ---
> 
> ...
> 
>> Thanks for sending this patch, will also send for AM62ax.
> 
> Please have a look at the couple of changes I did:
>   - corrected the label to be coherent with the datasheet and the other
>     peripheral names
>   - inverted "m_can" and "message_ram" regs/regs-names to fix a binding
>     checker error.
> 
> These might be relevant also for the AM62a.

Yes, already did. The changes look good to me, tested and everything 
works on AM62x. Did the same changes to AM62ax MCU dtsi. Thanks!

~ Judith