[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230724164521.tkyxpivqtsf222hb@litigator>
Date: Mon, 24 Jul 2023 11:45:21 -0500
From: Nishanth Menon <nm@...com>
To: Kamlesh Gurudasani <kamlesh@...com>
CC: Vignesh Raghavendra <vigneshr@...com>,
Tero Kristo <kristo@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Jayesh Choudhary <j-choudhary@...com>,
Herbert Xu <herbert@...dor.apana.org.au>,
"David S. Miller" <davem@...emloft.net>,
"Tero Kristo" <t-kristo@...com>, Keerthy <j-keerthy@...com>,
<linux-arm-kernel@...ts.infradead.org>,
<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
Rob Herring <robh@...nel.org>, <linux-crypto@...r.kernel.org>,
Conor Dooley <conor.dooley@...rochip.com>
Subject: Re: [PATCH v5 1/2] dt-bindings: crypto: ti,sa2ul: make power-domains
conditional
On 14:42-20230714, Kamlesh Gurudasani wrote:
> Devices specific to compatible ti,am62-sa3ul don't have control over
> power of SA3UL from main domain.
>
> "power-domains" property in crypto node tries to access
> the SA3UL power, for which it gets NACK and hence, driver doesn't
> probe properly for those particular devices.
>
> Make "power-domains" property as false for devices with
> compatible ti,am62-sa3ul.
>
> Fixes: 2ce9a7299bf6 ("dt-bindings: crypto: Add TI SA2UL crypto accelerator documentation")
>
> Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>
> Signed-off-by: Kamlesh Gurudasani <kamlesh@...com>
> ---
> Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
Herbert, Do you see a problem if I pick this patch via TI SoC Tree?
if you are OK, I'd like to take the series to keep it clean.
>
> diff --git a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> index 77ec8bc70bf7..f0ef7685550a 100644
> --- a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> +++ b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> @@ -66,10 +66,22 @@ patternProperties:
> required:
> - compatible
> - reg
> - - power-domains
> - dmas
> - dma-names
>
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: ti,am62-sa3ul
> + then:
> + properties:
> + power-domains: false
> + else:
> + required:
> + - power-domains
> +
> additionalProperties: false
>
> examples:
>
> --
> 2.34.1
>
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
Powered by blists - more mailing lists