[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <60e7e772-bf0a-264d-abac-4ed72766a2d0@linaro.org>
Date: Mon, 24 Jul 2023 19:05:03 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Rob Herring <robh@...nel.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Chunfeng Yun <chunfeng.yun@...iatek.com>,
Matthias Brugger <matthias.bgg@...il.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>,
Jagan Sridharan <badhri@...gle.com>,
ChiYuan Huang <cy_huang@...htek.com>,
Min Guo <min.guo@...iatek.com>,
Gene Chen <gene_chen@...htek.com>, linux-usb@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH] dt-bindings: usb: add missing unevaluatedProperties on
USB connector
On 24/07/2023 18:26, Rob Herring wrote:
> On Sun, Jul 23, 2023 at 09:11:05AM +0200, Krzysztof Kozlowski wrote:
>> The usb-connector.yaml schema allows any additional properties, thus its
>> usage should finish with unevaluatedProperties: false.
>
> Is it problematic if usb-connector.yaml is restricted?
Yes, a bit.
1. Missing reg/unit-address:
Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml
I guess this could be easily solved.
2. phy-supply:
arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
(and more of armada)
This is a bit odd:
phy@...00 {
compatible = "marvell,comphy-a3700";
comphy0: phy@0 {}
comphy1: phy@1 {}
comphy2: phy@2 {
connector {
compatible = "usb-a-connector";
phy-supply = <&exp_usb3_vbus>;
};
};
I would assume that phy-supply should be a property of the phy.
Best regards,
Krzysztof
Powered by blists - more mailing lists