[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230724-cleat-tricolor-e455afa60b14@spud>
Date: Mon, 24 Jul 2023 18:23:13 +0100
From: Conor Dooley <conor@...nel.org>
To: Jisheng Zhang <jszhang@...nel.org>
Cc: "David S . Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Giuseppe Cavallaro <peppe.cavallaro@...com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Jose Abreu <joabreu@...opsys.com>, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
linux-stm32@...md-mailman.stormreply.com,
linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH net-next 07/10] dt-bindings: net: snps,dwmac: add safety
irq support
On Mon, Jul 24, 2023 at 12:10:26AM +0800, Jisheng Zhang wrote:
> The snps dwmac IP support safety features, and those Safety Feature
> Correctible Error and Uncorrectible Error irqs may be separate irqs.
>
> Signed-off-by: Jisheng Zhang <jszhang@...nel.org>
> ---
> Documentation/devicetree/bindings/net/snps,dwmac.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> index ddf9522a5dc2..bb80ca205d26 100644
> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> @@ -107,6 +107,8 @@ properties:
> - description: Combined signal for various interrupt events
> - description: The interrupt to manage the remote wake-up packet detection
> - description: The interrupt that occurs when Rx exits the LPI state
> + - description: The interrupt that occurs when Safety Feature Correctible Errors happen
> + - description: The interrupt that occurs when Safety Feature Uncorrectible Errors happen
>
> interrupt-names:
> minItems: 1
> @@ -114,6 +116,8 @@ properties:
> - const: macirq
> - enum: [eth_wake_irq, eth_lpi]
> - const: eth_lpi
> + - const: sfty_ce_irq
> + - const: sfty_ue_irq
Putting _irq in an interrupt name seems rather redundant to me although,
clearly not the first time for it here.
Acked-by: Conor Dooley <conor.dooley@...rochip.com>
Thanks,
Conor.
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists