[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230724-unhappily-promptly-b25c7e42504d@spud>
Date: Mon, 24 Jul 2023 18:53:40 +0100
From: Conor Dooley <conor@...nel.org>
To: Swapnil Jakhade <sjakhade@...ence.com>
Cc: vkoul@...nel.org, kishon@...nel.org, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
linux-phy@...ts.infradead.org, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org, mparab@...ence.com, rogerq@...nel.org,
s-vadapalli@...com
Subject: Re: [PATCH 1/5] dt-bindings: phy: cadence-torrent: Add second
optional input reference clock
On Mon, Jul 24, 2023 at 04:59:58PM +0200, Swapnil Jakhade wrote:
> Torrent(SD0801) PHY supports two input reference clocks. Update bindings
> to support dual reference clock multilink configurations.
>
> Signed-off-by: Swapnil Jakhade <sjakhade@...ence.com>
> ---
> .../bindings/phy/phy-cadence-torrent.yaml | 23 +++++++++++++------
> 1 file changed, 16 insertions(+), 7 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml b/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml
> index dfb31314face..ddb86ee0cebf 100644
> --- a/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml
> +++ b/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml
> @@ -33,16 +33,25 @@ properties:
>
> clocks:
> minItems: 1
> - maxItems: 2
> + maxItems: 3
> description:
> - PHY reference clock for 1 item. Must contain an entry in clock-names.
> - Optional Parent to enable output reference clock.
> + PHY input reference clocks (refclk & refclk1).
"refclk" and "refclk1" don't seem like great names. What is each one
used for & should refclk1 be renamed to match its use case?
> + Optional Parent to enable output reference clock (phy_en_refclk).
>
> clock-names:
> - minItems: 1
> - items:
> - - const: refclk
> - - const: phy_en_refclk
> + oneOf:
> + - items:
> + - const: refclk
> + - items:
> + - const: refclk
> + - const: phy_en_refclk
> + - items:
> + - const: refclk
> + - const: refclk1
> + - items:
> + - const: refclk
> + - const: refclk1
> + - const: phy_en_refclk
>
> reg:
> minItems: 1
> --
> 2.34.1
>
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists