linux-kernel - Re: [PATCH 2/2] Input: lm8323

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZL7KghF8L+y1Fzcs@google.com>
Date:   Mon, 24 Jul 2023 12:01:22 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     linux-input@...r.kernel.org, Yangtao Li <frank.li@...o.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] Input: lm8323 - convert to use devm_* api

On Mon, Jul 24, 2023 at 08:53:11PM +0200, Christophe JAILLET wrote:
> Le 24/07/2023 à 07:29, Dmitry Torokhov a écrit :
> > From: Yangtao Li <frank.li@...o.com>
> > +
> > +		err = devm_led_classdev_register(dev, &pwm->cdev);

                      ^^^^^^^^^^^^^^

...

> > -
> > -	for (i = 0; i < 3; i++)
> > -		if (lm->pwm[i].enabled)
> > -			led_classdev_unregister(&lm->pwm[i].cdev);
> 
> this look wrong.

Why? It will be cleared up by devm.

Thanks.

-- 
Dmitry