linux-kernel - Re: [PATCH] pinctrl: qcom: Remove the unused

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a9f20ae3-74a3-fe3a-7de5-a57eb2d5aa81@kernel.org>
Date:   Mon, 24 Jul 2023 21:09:57 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Sricharan Ramabadhran <quic_srichara@...cinc.com>,
        agross@...nel.org, andersson@...nel.org, konrad.dybcio@...aro.org,
        linus.walleij@...aro.org, quic_varada@...cinc.com,
        linux-arm-msm@...r.kernel.org, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev,
        oe-kbuild-all@...ts.linux.dev
Subject: Re: [PATCH] pinctrl: qcom: Remove the unused _groups variable build
 warning

On 21/07/2023 12:12, Sricharan Ramabadhran wrote:
> When building with clang toolchain and arm64-randconfig-r015-20230712
> kernel test robot reports the below warning.
> 
>  drivers/pinctrl/qcom/pinctrl-ipq5018.c:244:27: warning: unused variable '_groups' [-Wunused-const-variable]
>    static const char * const _groups[] = {
>                              ^
>    1 warning generated.
> 
>      static const char * const _groups[] = {
>              "gpio0", "gpio1", "gpio2", "gpio3", "gpio4", "gpio5", "gpio6", "gpio7",
>              "gpio8", "gpio9", "gpio10", "gpio11", "gpio12", "gpio13", "gpio14",
>              "gpio15", "gpio16", "gpio17", "gpio18", "gpio19", "gpio20", "gpio21",
>              "gpio22", "gpio23", "gpio24", "gpio25", "gpio26", "gpio27", "gpio28",
>              "gpio29", "gpio30", "gpio31", "gpio32", "gpio33", "gpio34", "gpio35",
>              "gpio36", "gpio37", "gpio38", "gpio39", "gpio40", "gpio41", "gpio42",
>              "gpio43", "gpio44", "gpio45", "gpio46",
>    };
> 
> Fixing it by removing the variable.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202307120814.vWPY6URk-lkp@intel.com/
> Fixes: 725d1c891658 ("pinctrl: qcom: Add IPQ5018 pinctrl driver")
> Signed-off-by: Sricharan Ramabadhran <quic_srichara@...cinc.com>

This seems to be a duplicate of gpio_groups, so:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof