linux-kernel - Re: [PATCH] kstrtox: Remove strtobool()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 24 Jul 2023 21:16:30 +0200
From:   Christophe JAILLET <christophe.jaillet@...adoo.fr>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     andriy.shevchenko@...ux.intel.com, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] kstrtox: Remove strtobool()

Le 24/07/2023 à 20:05, Andrew Morton a écrit :
> On Thu, 20 Jul 2023 22:40:35 +0200 Christophe JAILLET <christophe.jaillet@...adoo.fr> wrote:
> 
>> The conversion from strtobool() to kstrtobool() is completed.
>> So strtobool() can now be removed.
> 
> I still have some strtobool()s in mm.git, so I can't apply this.
> 
> Probably nobody can apply this to their tree at this stage.  A resend
> after 6.6-rc1 would be the simplest approach.
> 
> 

Let's do it then.

Note that in -next there is still some strtobool but only in tools/.
I thinks it is ok to leave it as-is.


git grep -w strtobool

tools/include/linux/string.h:int strtobool(const char *s, bool *res);
tools/lib/string.c: *  More specifically, the first copied function was 
strtobool, which
tools/lib/string.c: *  d0f1fed29e6e ("Add a strtobool function matching 
semantics of existing in kernel equivalents")
tools/lib/string.c: * strtobool - convert common user inputs into 
boolean values
tools/lib/string.c:int strtobool(const char *s, bool *res)
tools/perf/util/bpf-loader.c:   err = strtobool(value, &bool_value);


CJ