linux-kernel - Re: [PATCH] drm/radeon: add missing spaces after ',' and else should follow close brace '}'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 24 Jul 2023 17:39:24 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     sunran001@...suo.com
Cc:     alexander.deucher@....com, dri-devel@...ts.freedesktop.org,
        amd-gfx@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/radeon: add missing spaces after ',' and else should
 follow close brace '}'

Applied.  Thanks!

Alex

On Sun, Jul 23, 2023 at 11:30 PM <sunran001@...suo.com> wrote:
>
> ERROR: else should follow close brace '}'
>
> ERROR: space required after that ',' (ctx:VxV)
>
> Signed-off-by: Ran Sun <sunran001@...suo.com>
> ---
>   drivers/gpu/drm/radeon/radeon_connectors.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c
> b/drivers/gpu/drm/radeon/radeon_connectors.c
> index 07193cd0c417..4ceceb972e8d 100644
> --- a/drivers/gpu/drm/radeon/radeon_connectors.c
> +++ b/drivers/gpu/drm/radeon/radeon_connectors.c
> @@ -198,8 +198,7 @@ int radeon_get_monitor_bpc(struct drm_connector
> *connector)
>                                 DRM_DEBUG("%s: HDMI deep color 10 bpc exceeds max tmds clock. Using
> %d bpc.\n",
>                                                   connector->name, bpc);
>                         }
> -               }
> -               else if (bpc > 8) {
> +               } else if (bpc > 8) {
>                         /* max_tmds_clock missing, but hdmi spec mandates it for deep color.
> */
>                         DRM_DEBUG("%s: Required max tmds clock for HDMI deep color missing.
> Using 8 bpc.\n",
>                                           connector->name);
> @@ -1372,7 +1371,7 @@ radeon_dvi_detect(struct drm_connector *connector,
> bool force)
>                                         /* assume digital unless load detected otherwise */
>                                         radeon_connector->use_digital = true;
>                                         lret = encoder_funcs->detect(encoder, connector);
> -                                       DRM_DEBUG_KMS("load_detect %x returned:
> %x\n",encoder->encoder_type,lret);
> +                                       DRM_DEBUG_KMS("load_detect %x returned: %x\n",
> encoder->encoder_type, lret);
>                                         if (lret == connector_status_connected)
>                                                 radeon_connector->use_digital = false;
>                                 }