[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CADnq5_M4uLoVGn02NC7bCFwbMieOsr7MOzSoTXgXnruDNzCy4g@mail.gmail.com>
Date: Mon, 24 Jul 2023 17:44:14 -0400
From: Alex Deucher <alexdeucher@...il.com>
To: sunran001@...suo.com
Cc: alexander.deucher@....com, dri-devel@...ts.freedesktop.org,
amd-gfx@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/radeon: Move assignment outside if condition
Applied. Thanks!
On Sun, Jul 23, 2023 at 11:45 PM <sunran001@...suo.com> wrote:
>
> Fixes the following checkpatch errors:
>
> ERROR: do not use assignment in if condition
>
> Signed-off-by: Ran Sun <sunran001@...suo.com>
> ---
> drivers/gpu/drm/radeon/radeon_legacy_tv.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_legacy_tv.c
> b/drivers/gpu/drm/radeon/radeon_legacy_tv.c
> index 12e180b119ac..7883e9ec0bae 100644
> --- a/drivers/gpu/drm/radeon/radeon_legacy_tv.c
> +++ b/drivers/gpu/drm/radeon/radeon_legacy_tv.c
> @@ -724,12 +724,14 @@ void radeon_legacy_tv_mode_set(struct drm_encoder
> *encoder,
> }
>
> for (i = 0; i < MAX_H_CODE_TIMING_LEN; i++) {
> - if ((tv_dac->tv.h_code_timing[i] = hor_timing[i]) == 0)
> + tv_dac->tv.h_code_timing[i] = hor_timing[i];
> + if (tv_dac->tv.h_code_timing[i] == 0)
> break;
> }
>
> for (i = 0; i < MAX_V_CODE_TIMING_LEN; i++) {
> - if ((tv_dac->tv.v_code_timing[i] = vert_timing[i]) == 0)
> + tv_dac->tv.v_code_timing[i] = vert_timing[i];
> + if (tv_dac->tv.v_code_timing[i] == 0)
> break;
> }
Powered by blists - more mailing lists