linux-kernel - Re: [PATCH AUTOSEL 4.14 3/9] xhci: Don't require a valid get_quirks() function pointer during xhci setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2023072426-impart-neatness-d0e0@gregkh>
Date:   Mon, 24 Jul 2023 06:08:35 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Sasha Levin <sashal@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Mathias Nyman <mathias.nyman@...ux.intel.com>,
        mathias.nyman@...el.com, linux-usb@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 4.14 3/9] xhci: Don't require a valid
 get_quirks() function pointer during xhci setup

On Sun, Jul 23, 2023 at 09:35:45PM -0400, Sasha Levin wrote:
> From: Mathias Nyman <mathias.nyman@...ux.intel.com>
> 
> [ Upstream commit 9b907c91aa94522ae14bf155ce7b9ccb10a0903c ]
> 
> Not all platforms drivers need to set up custom quirks during the xhci
> generic setup. Allow them to pass NULL as the function pointer when
> calling xhci_gen_setup()
> 
> Signed-off-by: Mathias Nyman <mathias.nyman@...ux.intel.com>
> Message-ID: <20230602144009.1225632-4-mathias.nyman@...ux.intel.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Signed-off-by: Sasha Levin <sashal@...nel.org>
> ---
>  drivers/usb/host/xhci.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> index 0f2b67f38d2ea..3feee0419fdd9 100644
> --- a/drivers/usb/host/xhci.c
> +++ b/drivers/usb/host/xhci.c
> @@ -4975,7 +4975,8 @@ int xhci_gen_setup(struct usb_hcd *hcd, xhci_get_quirks_t get_quirks)
>  
>  	xhci->quirks |= quirks;
>  
> -	get_quirks(dev, xhci);
> +	if (get_quirks)
> +		get_quirks(dev, xhci);

Not needed in 4.14.y, thanks.

greg k-h