linux-kernel - RE: [EXT] Re: [PATCH v3 1/7] dt-bindings: arm: fsl: add mu binding doc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DU2PR04MB86309B90B0849AFB23F6462F9502A@DU2PR04MB8630.eurprd04.prod.outlook.com>
Date:   Mon, 24 Jul 2023 06:37:33 +0000
From:   Pankaj Gupta <pankaj.gupta@....com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "conor+dt@...nel.org" <conor+dt@...nel.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        dl-linux-imx <linux-imx@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Gaurav Jain <gaurav.jain@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Daniel Baluta <daniel.baluta@....com>
Subject: RE: [EXT] Re: [PATCH v3 1/7] dt-bindings: arm: fsl: add mu binding
 doc



> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Sent: Thursday, July 13, 2023 12:12 AM
> To: Pankaj Gupta <pankaj.gupta@....com>; robh+dt@...nel.org;
> krzysztof.kozlowski+dt@...aro.org; conor+dt@...nel.org;
> shawnguo@...nel.org; s.hauer@...gutronix.de; kernel@...gutronix.de;
> festevam@...il.com; dl-linux-imx <linux-imx@....com>;
> devicetree@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; Gaurav
> Jain <gaurav.jain@....com>; linux-kernel@...r.kernel.org; Daniel Baluta
> <daniel.baluta@....com>
> Subject: Re: [EXT] Re: [PATCH v3 1/7] dt-bindings: arm: fsl: add mu binding
> doc
> 
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
> 
> 
> On 10/07/2023 19:52, Pankaj Gupta wrote:
> >
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> >> Sent: Friday, June 16, 2023 6:51 PM
> >> To: Pankaj Gupta <pankaj.gupta@....com>; robh+dt@...nel.org;
> >> krzysztof.kozlowski+dt@...aro.org; conor+dt@...nel.org;
> >> shawnguo@...nel.org; s.hauer@...gutronix.de; kernel@...gutronix.de;
> >> festevam@...il.com; dl-linux-imx <linux-imx@....com>;
> >> devicetree@...r.kernel.org; linux-arm-kernel@...ts.infradead.org;
> >> Gaurav Jain <gaurav.jain@....com>; linux-kernel@...r.kernel.org;
> >> Daniel Baluta <daniel.baluta@....com>
> >> Subject: [EXT] Re: [PATCH v3 1/7] dt-bindings: arm: fsl: add mu
> >> binding doc
> >>
> >> Caution: This is an external email. Please take care when clicking
> >> links or opening attachments. When in doubt, report the message using
> >> the 'Report this email' button
> >>
> >>
> >> On 16/06/2023 20:11, Pankaj Gupta wrote:
> >>> The NXP i.MX Message Unit enables two processing elements to
> >>> communicate & co-ordinate with each other. This driver is used to
> >>> communicate between Application Core and NXP HSM IPs like NXP
> >> EdgeLock
> >>> Enclave etc.
> >>> It exists on some i.MX processors. e.g. i.MX8ULP, i.MX93 etc.
> >>>
> >>> Signed-off-by: Pankaj Gupta <pankaj.gupta@....com>
> >>
> >> I don't see reply to Daniel's concerns.
> >>
> >> I don't see improvements here based on the previous review you received.
> >> It seems you just ignored everything, right?
> > Replied to Daniel's concern.
> >
> >>
> >> Limited review follows up because binding is not in the shape for upstream.
> >> Do some internal reviews prior sending it.
> > Done the internal review.
> 
> I doubt. Your v4 bindings and DTS were not tested. v4 Driver has trivial issues.
> 
It is tested and my driver get probed. And all my functional tests are passing.
No Patch-set is sent without testing.

> Best regards,
> Krzysztof