linux-kernel - [HID Patchsets v1 2/2] HID: Removed USB Validation check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230724084752.371245-3-sandeep.cs@samsung.com>
Date:   Mon, 24 Jul 2023 14:17:51 +0530
From:   "sandeep.cs" <sandeep.cs@...sung.com>
To:     Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>
Cc:     junwan.cho@...sung.com, jitender.s21@...sung.com,
        suhyun_.kim@...sung.com, ih0923.kim@...sung.com,
        gaudium.lee@...sung.com, sandeep.cs@...sung.com,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [HID Patchsets v1 2/2] HID: Removed USB Validation check

Earlier Samsung driver only handles USB HID devices and returns an error if it encounters a Bluetooth type of HID device.
By removing this USB validation check, we allow the driver to handle other types of HID devices including Bluetooth HID devices, which were previously excluded.

This change improves driver compatibility and extends its support for a wide range of devices.

Signed-off-by: Sandeep C S<sandeep.cs@...sung.com>
Signed-off-by: Junwan Cho <junwan.cho@...sung.com>
Signed-off-by: Jitender Sajwan <jitender.s21@...sung.com>
---
 drivers/hid/hid-samsung.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/hid/hid-samsung.c b/drivers/hid/hid-samsung.c
index 33e963303d11..3cafbf4d9dc6 100644
--- a/drivers/hid/hid-samsung.c
+++ b/drivers/hid/hid-samsung.c
@@ -517,9 +517,6 @@ static int samsung_probe(struct hid_device *hdev,
 	int ret;
 	unsigned int cmask = HID_CONNECT_DEFAULT;
 
-	if (!hid_is_usb(hdev))
-		return -EINVAL;
-
 	ret = hid_parse(hdev);
 	if (ret) {
 		hid_err(hdev, "parse failed\n");
-- 
2.25.1