linux-kernel - Re: [PATCH] m68k: q40: prefer 'unsigned int' to bare use of 'unsigned'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdVOXvNykCmzJij=ZrVCxnM0DSrwB4_mX6c8-d7ztzNSUA@mail.gmail.com>
Date:   Mon, 24 Jul 2023 10:55:18 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     xuanzhenggang001@...suo.com
Cc:     linux-m68k@...ts.linux-m68k.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] m68k: q40: prefer 'unsigned int' to bare use of 'unsigned'

Hi Zhenggang,

On Sat, Jul 8, 2023 at 6:06 PM <xuanzhenggang001@...suo.com> wrote:
> Fix the following warnings reported by checkpatch:
>
> ./arch/m68k/q40/q40ints.c:172: WARNING: Prefer 'unsigned int' to bare
> use of 'unsigned'
> ./arch/m68k/q40/q40ints.c:211: WARNING: Prefer 'unsigned int' to bare
> use of 'unsigned'
>
> Signed-off-by: Zhenggang Xuan <xuanzhenggang001@...suo.com>

Thanks for your patch!

But obviously you forgot to run scripts/checkpatch.pl on your own patch:

    WARNING: From:/Signed-off-by: email name mismatch: 'From:
xuanzhenggang001@...suo.com' != 'Signed-off-by: Zhenggang Xuan
<xuanzhenggang001@...suo.com>'

> --- a/arch/m68k/q40/q40ints.c
> +++ b/arch/m68k/q40/q40ints.c
> @@ -169,7 +169,7 @@ void q40_sched_init (void)
>    *
>   */
>
> -struct IRQ_TABLE{ unsigned mask; int irq ;};
> +struct IRQ_TABLE { unsigned int mask ; int irq ; };
>   #if 0
>   static struct IRQ_TABLE iirqs[]={
>     {Q40_IRQ_FRAME_MASK,Q40_IRQ_FRAME},
> @@ -208,7 +208,7 @@ static int aliased_irq;        /* how many times
> inside handler ?*/
>   /* got interrupt, dispatch to ISA or keyboard/timer IRQs */
>   static void q40_irq_handler(unsigned int irq, struct pt_regs *fp)
>   {
> -    unsigned mir, mer;
> +    unsigned int mir, mer;

This part is white-space damaged, and thus fails to apply.

>       int i;
>
>   //repeat:

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds