linux-kernel - Re: [PATCH] m68k: sun3: idprom: ERROR: "foo* bar" should be "foo *bar"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdViE_OMQC=Y9T30oK6Ho1zXegLoYN4KhWGHzuimkpeGTA@mail.gmail.com>
Date:   Mon, 24 Jul 2023 11:00:37 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     hexingwei001@...suo.com
Cc:     sammy@...my.net, linux-m68k@...ts.linux-m68k.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] m68k: sun3: idprom: ERROR: "foo* bar" should be "foo *bar"

On Thu, Jul 13, 2023 at 10:09 AM <hexingwei001@...suo.com> wrote:
> Fix one occurrences of the checkpatch.pl error:
> ERROR: "foo* bar" should be "foo *bar"
>
> Signed-off-by: Xingwei He <hexingwei001@...suo.com>

Thanks for your patch!
But obviously you forgot to run scripts/checkpatch.pl on your own patch:

WARNING: From:/Signed-off-by: email name mismatch: 'From:
hexingwei001@...suo.com' != 'Signed-off-by: Xingwei He
<hexingwei001@...suo.com>'

> --- a/arch/m68k/sun3/idprom.c
> +++ b/arch/m68k/sun3/idprom.c
> @@ -83,7 +83,7 @@ static void __init display_system_type(unsigned char
> machtype)
>       prom_halt();
>   }
>
> -void sun3_get_model(unsigned char* model)
> +void sun3_get_model(unsigned char *model)
>   {
>       register int i;

Whitespace-damaged, so it fails to apply.

These problems are present in all your patches, so something is\
wrong in your workflow.  Please test your patches by running
scripts/checkpatch.pl, emailing them to yourself, and trying to
apply them.

Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds