linux-kernel - Re: [PATCH 09/11] dt-bindings: arm: msm: kpss-acc: Make the optional reg truly optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4d8143bc-03db-4f6b-9833-44cbaf95ecac@linaro.org>
Date:   Mon, 24 Jul 2023 11:12:30 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>,
        cros-qcom-dts-watchers@...omium.org,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Benjamin Li <benl@...areup.com>,
        James Willcox <jwillcox@...areup.com>,
        Joseph Gates <jgates@...areup.com>,
        Stephan Gerhold <stephan@...hold.net>,
        Zac Crosby <zac@...areup.com>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Banajit Goswami <bgoswami@...cinc.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>, Lee Jones <lee@...nel.org>,
        Stephen Boyd <sboyd@...nel.org>,
        Joerg Roedel <joro@...tes.org>, Will Deacon <will@...nel.org>,
        Robin Murphy <robin.murphy@....com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Xu Yang <xu.yang_2@....com>, Peng Fan <peng.fan@....com>,
        Christian Marangi <ansuelsmth@...il.com>,
        Wesley Cheng <quic_wcheng@...cinc.com>,
        Jun Nie <jun.nie@...aro.org>, Max Chen <mchen@...areup.com>,
        Shawn Guo <shawn.guo@...aro.org>,
        Vivek Gautam <vivek.gautam@...eaurora.org>
Cc:     Marijn Suijten <marijn.suijten@...ainline.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Vincent Knecht <vincent.knecht@...loo.org>,
        Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
        Konrad Dybcio <konradybcio@...nel.org>,
        alsa-devel@...a-project.org, iommu@...ts.linux.dev,
        linux-usb@...r.kernel.org, Leo Yan <leo.yan@...aro.org>,
        Rob Herring <robh@...nel.org>,
        Andy Gross <andy.gross@...aro.org>
Subject: Re: [PATCH 09/11] dt-bindings: arm: msm: kpss-acc: Make the optional
 reg truly optional

On 24/07/2023 11:05, Krzysztof Kozlowski wrote:
> On 27/06/2023 18:24, Konrad Dybcio wrote:
>> The description of reg[1] says that register is optional. Adjust
>> minItems to make it truly optional.
>>
>> Fixes: 12f40018b6a9 ("dt-bindings: arm: msm: Convert kpss-acc driver Documentation to yaml")
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@...aro.org>
>> ---
> 
> This patch does not make sense. It wasn't also tested. The code
> (minItems) is already there.


What's more - there is no such commit as 12f40018b6a9!

Bjorn,
You might find this useful (fake Fixes tag should be detected):
https://github.com/krzk/tools/blob/master/linux/git-hooks-post-commit

Best regards,
Krzysztof