linux-kernel - Re: [PATCH net-next] page_pool: split types and declarations from page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b28c02a8-8263-47e3-ffcf-51c992f03d30@intel.com>
Date:   Mon, 24 Jul 2023 12:18:25 +0200
From:   Alexander Lobakin <aleksander.lobakin@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     Yunsheng Lin <linyunsheng@...wei.com>, <davem@...emloft.net>,
        <pabeni@...hat.com>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, Eric Dumazet <edumazet@...gle.com>,
        Wei Fang <wei.fang@....com>,
        Shenwei Wang <shenwei.wang@....com>,
        Clark Wang <xiaoning.wang@....com>,
        NXP Linux Team <linux-imx@....com>,
        Sunil Goutham <sgoutham@...vell.com>,
        Geetha sowjanya <gakula@...vell.com>,
        "Subbaraya Sundeep" <sbhatta@...vell.com>,
        hariprasad <hkelam@...vell.com>,
        "Saeed Mahameed" <saeedm@...dia.com>,
        Leon Romanovsky <leon@...nel.org>,
        "Alexei Starovoitov" <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        "Jesper Dangaard Brouer" <hawk@...nel.org>,
        John Fastabend <john.fastabend@...il.com>,
        Felix Fietkau <nbd@....name>,
        Lorenzo Bianconi <lorenzo@...nel.org>,
        "Ryder Lee" <ryder.lee@...iatek.com>,
        Shayne Chen <shayne.chen@...iatek.com>,
        "Sean Wang" <sean.wang@...iatek.com>,
        Kalle Valo <kvalo@...nel.org>,
        "Matthias Brugger" <matthias.bgg@...il.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        Ilias Apalodimas <ilias.apalodimas@...aro.org>,
        <linux-rdma@...r.kernel.org>, <bpf@...r.kernel.org>,
        <linux-wireless@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH net-next] page_pool: split types and declarations from
 page_pool.h

From: Jakub Kicinski <kuba@...nel.org>
Date: Fri, 21 Jul 2023 18:29:42 -0700

> On Fri, 21 Jul 2023 17:51:17 +0200 Alexander Lobakin wrote:
>>>> More specificly, yon means the below, right?
>>>> include/net/page_pool.h
>>>> include/net/page_pool/types.h  
>>>
>>> Yes.  
>>
>> What I meant is
>>
>> include/net/page_pool/types.h
>> include/net/page_pool/driver.h
>>
>> I'm not insisting, just to be clear :)
> 
> I thought we already talked about naming headers after the user :S
> Unless you're _defining_ a driver in driver.h that's not a good name.
> types.h, helpers.h, functions.h, dma.h are good names.

Ah, sure :) I was mostly talking about

include/net/page_pool.h
include/net/page_pool/types.h

vs

include/net/page_pool/helpers.h (or functions.h)
include/net/page_pool/types.h

I.e. whether to have a header with the same name next to the folder or
place everything in that folder.

Thanks,
Olek