linux-kernel - Re: [PATCH v1] skbuff: remove unused HAVE_HW_TIME

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZL5gO1PZyrYS0ft0@corigine.com>
Date:   Mon, 24 Jul 2023 13:27:55 +0200
From:   Simon Horman <simon.horman@...igine.com>
To:     Peter Seiderer <ps.report@....net>
Cc:     linux-kernel@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Yunsheng Lin <linyunsheng@...wei.com>,
        Pavel Begunkov <asml.silence@...il.com>,
        Richard Gobert <richardbgobert@...il.com>
Subject: Re: [PATCH v1] skbuff: remove unused HAVE_HW_TIME_STAMP feature
 define

On Fri, Jul 21, 2023 at 09:18:05PM +0200, Peter Seiderer wrote:
> Remove unused HAVE_HW_TIME_STAMP feature define (introduced by
> commit ac45f602ee3d ("net: infrastructure for hardware time stamping").
> 
> Signed-off-by: Peter Seiderer <ps.report@....net>

Hi Peter,

this patch looks good to me, however a few tweaks are needed to the
submission in order for it to enter the review pipeline, and thus
path to being accepted.

1. For networking patches, please specify the target tree.
   Fixes go to 'net'. Other patches go to 'net-next'
   This appears to be in the latter category. So:

   Subject: [PATCH net-next] ...

2. Looking at the git history of include/linux/skbuff.h,
   it seems that 'net: skbuff: is the preferred prefix.
   So:

   Subject: [PATCH net-next] net: skubff: ...

3. Please CC netdev@...r.kernel.org

   This is the most important part, else our automated systems don't see
   the patch, and it doesn't exist in the pipeline.

   As an aside, in general, and in this case, there is no need to copy
   linux-kernel@...r.kernel.org on Networking patches.

4. Please do CC parties to any patches mentioned, in this case
   ac45f602ee3d. Which I think means:

   Patrick Ohly <patrick.ohly@...el.com>

Ref: https://docs.kernel.org/process/maintainer-netdev.html

> ---
>  include/linux/skbuff.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
> index faaba050f843..16a49ba534e4 100644
> --- a/include/linux/skbuff.h
> +++ b/include/linux/skbuff.h
> @@ -441,8 +441,6 @@ static inline bool skb_frag_must_loop(struct page *p)
>  	     copied += p_len, p++, p_off = 0,				\
>  	     p_len = min_t(u32, f_len - copied, PAGE_SIZE))		\
>  
> -#define HAVE_HW_TIME_STAMP
> -
>  /**
>   * struct skb_shared_hwtstamps - hardware time stamps
>   * @hwtstamp:		hardware time stamp transformed into duration
> -- 
> 2.41.0
>