linux-kernel - Re: [PATCH -next] hv: hyperv.h: Remove unused extern declaration vmbus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 25 Jul 2023 22:17:23 +0800
From:   YueHaibing <yuehaibing@...wei.com>
To:     "Michael Kelley (LINUX)" <mikelley@...rosoft.com>,
        KY Srinivasan <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        "wei.liu@...nel.org" <wei.liu@...nel.org>,
        Dexuan Cui <decui@...rosoft.com>
CC:     "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] hv: hyperv.h: Remove unused extern declaration
 vmbus_ontimer()

On 2023/7/25 22:12, Michael Kelley (LINUX) wrote:
> From: YueHaibing <yuehaibing@...wei.com> Sent: Tuesday, July 25, 2023 6:59 AM
>>
> 
> I'd suggest using "Drivers: hv: vmbus:" as the prefix in the commit message Subject.
> I see that "hv: hyperv.h:" has been used a few times in the past, but my suggestion
> is much more commonly used and would give better overall consistency.

Ok, will send v2.
> 
>> Since commit 30fbee49b071 ("Staging: hv: vmbus: Get rid of the unused function
>> vmbus_ontimer()")
>> this is not used anymore, so can remove it.
> 
> Indeed, yes!
> 
> Reviewed-by: Michael Kelley <mikelley@...rosoft.com>
> 
>>
>> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
>> ---
>>  include/linux/hyperv.h | 3 ---
>>  1 file changed, 3 deletions(-)
>>
>> diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
>> index bfbc37ce223b..3ac3974b3c78 100644
>> --- a/include/linux/hyperv.h
>> +++ b/include/linux/hyperv.h
>> @@ -1239,9 +1239,6 @@ extern int vmbus_recvpacket_raw(struct vmbus_channel
>> *channel,
>>  				     u32 *buffer_actual_len,
>>  				     u64 *requestid);
>>
>> -
>> -extern void vmbus_ontimer(unsigned long data);
>> -
>>  /* Base driver object */
>>  struct hv_driver {
>>  	const char *name;
>> --
>> 2.34.1
> 
> .
>