linux-kernel - Re: [PATCH v6] wifi: ath5k: remove phydir check from ath5k_debug_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <169029540951.3210124.15107643923652179216.kvalo@kernel.org>
Date:   Tue, 25 Jul 2023 14:30:11 +0000 (UTC)
From:   Kalle Valo <kvalo@...nel.org>
To:     Minjie Du <duminjie@...o.com>
Cc:     Jiri Slaby <jirislaby@...nel.org>,
        Nick Kossifidis <mickflemm@...il.com>,
        Luis Chamberlain <mcgrof@...nel.org>,
        linux-wireless@...r.kernel.org (open list:ATHEROS ATH5K WIRELESS DRIVER),
        linux-kernel@...r.kernel.org (open list),
        opensource.kernel@...o.com, Minjie Du <duminjie@...o.com>
Subject: Re: [PATCH v6] wifi: ath5k: remove phydir check from
 ath5k_debug_init_device()

Minjie Du <duminjie@...o.com> wrote:

> 'phydir' returned from debugfs_create_dir() is checked against NULL.
> As the debugfs API returns an error pointer,
> the returned value can never be NULL.
> 
> Therefore, as the documentation suggests that the check is unnecessary
> and other debugfs calls have no operation in error cases,
> it is advisable to completely eliminate the check.
> 
> Signed-off-by: Minjie Du <duminjie@...o.com>
> Reviewed-by: Jiri Slaby <jirislaby@...nel.org>
> Signed-off-by: Kalle Valo <quic_kvalo@...cinc.com>

Patch applied to ath-next branch of ath.git, thanks.

f7eb8315b22a wifi: ath5k: remove phydir check from ath5k_debug_init_device()

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20230714081619.2032-1-duminjie@vivo.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches