linux-kernel - Re: [PATCH] platform/x86: huawei-wmi: Silence ambient light sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 25 Jul 2023 16:38:52 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Konstantin Shelekhin <k.shelekhin@...l.net>,
        Mark Gross <markgross@...nel.org>,
        Ayman Bagabas <ayman.bagabas@...il.com>
Cc:     platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/x86: huawei-wmi: Silence ambient light sensor

Hi,

On 7/22/23 17:59, Konstantin Shelekhin wrote:
> Currently huawei-wmi causes a lot of spam in dmesg on my
> Huawei MateBook X Pro 2022:
> 
>   ...
>   [36409.328463] input input9: Unknown key pressed, code: 0x02c1
>   [36411.335104] input input9: Unknown key pressed, code: 0x02c1
>   [36412.338674] input input9: Unknown key pressed, code: 0x02c1
>   [36414.848564] input input9: Unknown key pressed, code: 0x02c1
>   [36416.858706] input input9: Unknown key pressed, code: 0x02c1
>   ...
> 
> Fix that by ignoring events generated by ambient light sensor.
> 
> This issue was reported on GitHub and resolved with the following merge
> request:
> 
>   https://github.com/aymanbagabas/Huawei-WMI/pull/70
> 
> I've contacted the mainter of this repo and he gave me the "go ahead" to
> send this patch to the maling list.
> 
> Signed-off-by: Konstantin Shelekhin <k.shelekhin@...l.net>

Thank you for your patch, I've applied this patch to my fixes
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=fixes

Note it will show up in my fixes branch once I've pushed my
local branch there, which might take a while.

I will include this patch in my next fixes pull-req to Linus
for the current kernel development cycle.

Regards,

Hans



> ---
>  drivers/platform/x86/huawei-wmi.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/platform/x86/huawei-wmi.c b/drivers/platform/x86/huawei-wmi.c
> index 70e5c4c0574d..0ef1c46b617b 100644
> --- a/drivers/platform/x86/huawei-wmi.c
> +++ b/drivers/platform/x86/huawei-wmi.c
> @@ -85,6 +85,8 @@ static const struct key_entry huawei_wmi_keymap[] = {
>  	{ KE_IGNORE, 0x293, { KEY_KBDILLUMTOGGLE } },
>  	{ KE_IGNORE, 0x294, { KEY_KBDILLUMUP } },
>  	{ KE_IGNORE, 0x295, { KEY_KBDILLUMUP } },
> +	// Ignore Ambient Light Sensoring
> +	{ KE_KEY,    0x2c1, { KEY_RESERVED } },
>  	{ KE_END,	 0 }
>  };
>