linux-kernel - Re: [PATCH] kvm: vmx: fix a trivial comment in vmx_vcpu_after_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZL/hlrWFzrtcdcmH@google.com>
Date:   Tue, 25 Jul 2023 07:52:06 -0700
From:   Sean Christopherson <seanjc@...gle.com>
To:     Yi Wang <up2wing@...il.com>
Cc:     pbonzini@...hat.com, tglx@...utronix.de, mingo@...hat.com,
        bp@...en8.de, dave.hansen@...ux.intel.com, hpa@...or.com,
        kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
        wanpengli@...cent.com, Yi Wang <foxywang@...cent.com>
Subject: Re: [PATCH] kvm: vmx: fix a trivial comment in vmx_vcpu_after_set_cpuid()

On Tue, Jul 25, 2023, Yi Wang wrote:
> The commit b6247686b7571 ("KVM: VMX: Drop caching of KVM's desired
> sec exec controls for vmcs01") renamed vmx_compute_secondary_exec_control()
> to vmx_secondary_exec_control(), but forgot to modify the comment.
> 
> Signed-off-by: Yi Wang <foxywang@...cent.com>
> ---
>  arch/x86/kvm/vmx/vmx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
> index 0ecf4be2c6af..26d62990fea7 100644
> --- a/arch/x86/kvm/vmx/vmx.c
> +++ b/arch/x86/kvm/vmx/vmx.c
> @@ -7722,7 +7722,7 @@ static void vmx_vcpu_after_set_cpuid(struct kvm_vcpu *vcpu)
>  {
>  	struct vcpu_vmx *vmx = to_vmx(vcpu);
>  
> -	/* xsaves_enabled is recomputed in vmx_compute_secondary_exec_control(). */
> +	/* xsaves_enabled is recomputed in vmx_secondary_exec_control(). */
>  	vcpu->arch.xsaves_enabled = false;

I have an in-progress patch[*] that reworks this code and wipes out the stale
comment as a side effect.  Thank you though!

[*] https://lore.kernel.org/all/20230217231022.816138-4-seanjc@google.com