[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <0340a749-7073-4002-ada4-c1866f90054d@roeck-us.net>
Date: Tue, 25 Jul 2023 08:19:48 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Andre Werner <werneazc@...il.com>
Cc: jdelvare@...e.com, krzysztof.kozlowski+dt@...aro.org,
conor+dt@...nel.org, robh+dt@...nel.org,
linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org,
Andre Werner <andre.werner@...tec-electronic.com>
Subject: Re: [PATCH v3 1/2] dt-bindings: hwmon: Add description for new hwmon
driver hs3001
On Tue, Jul 18, 2023 at 01:28:09PM +0200, Andre Werner wrote:
> This is the initial description.
>
> Signed-off-by: Andre Werner <andre.werner@...tec-electronic.com>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
checkpatch:
WARNING: From:/Signed-off-by: email address mismatch: 'From: Andre Werner <werneazc@...il.com>' != 'Signed-off-by: Andre Werner <andre.werner@...tec-electronic.com>'
Sorry, you'll have to resend this. The e-mail addresses need to match.
Note that, when doing so, I would suggest to add a sensible description.
"This is the initial description." is not a useful description.
"Add binding for Renesas HS3001 Temperature and Relative Humidity Sensor"
would be more sensible. Also, regarding the subject: bindings don't describe
the driver, they describe the chip.
Thanks,
Guenter
> ---
> v1: Using separate dt-binding hs300x.yaml
> v2: Reviewer recommends documentation of driver dt-binding in
> trivial-devices.yaml because the driver has no special properties
> to describe.
> v3: Simplify description of sensors compatible
> ---
> Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index ba2bfb547909..96eb59e56eb7 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -315,6 +315,8 @@ properties:
> - plx,pex8648
> # Pulsedlight LIDAR range-finding sensor
> - pulsedlight,lidar-lite-v2
> + # Renesas HS3001 Temperature and Relative Humidity Sensors
> + - renesas,hs3001
> # Renesas ISL29501 time-of-flight sensor
> - renesas,isl29501
> # Rohm DH2228FV
Powered by blists - more mailing lists