linux-kernel - [PATCH v8 1/3] fault-inject: Include linux/types.h by default.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20230725155115.3759312-2-himal.prasad.ghimiray@intel.com>
Date:   Tue, 25 Jul 2023 21:21:13 +0530
From:   Himal Prasad Ghimiray <himal.prasad.ghimiray@...el.com>
To:     intel-xe@...ts.freedesktop.org
Cc:     Himal Prasad Ghimiray <himal.prasad.ghimiray@...el.com>,
        Lucas De Marchi <lucas.demarchi@...el.com>,
        Rodrigo Vivi <rodrigo.vivi@...el.com>,
        Badal Nilawar <badal.nilawar@...el.com>,
        Akinobu Mita <akinobu.mita@...il.com>,
        Jason Gunthorpe <jgg@...pe.ca>, Jens Axboe <axboe@...nel.dk>,
        Qi Zheng <zhengqi.arch@...edance.com>,
        linux-kernel@...r.kernel.org
Subject: [PATCH v8 1/3] fault-inject: Include linux/types.h by default.

Functions should_fail_alloc_page, should_failslab, and __should_failslab
are declared irrespective of CONFIG_FAULT_INJECTION. These functions use
bool and gfp_t types, which are treated as unknown when CONFIG_FAULT_INJECTION
is disabled because the inclusion of linux/types.h is missing.

Fixes: 6ff1cb355e62 ("[PATCH] fault-injection capabilities infrastructure")

v2:
- Add fixes tag (Badal)
- Rectify Cc. (Lucas)

Cc: Lucas De Marchi <lucas.demarchi@...el.com>
Cc: Rodrigo Vivi <rodrigo.vivi@...el.com>
Cc: Badal Nilawar <badal.nilawar@...el.com>
Cc: Akinobu Mita <akinobu.mita@...il.com>
Cc: Jason Gunthorpe <jgg@...pe.ca>
Cc: Jens Axboe <axboe@...nel.dk>
Cc: Qi Zheng <zhengqi.arch@...edance.com>
Cc: linux-kernel@...r.kernel.org
Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@...el.com>
---
 include/linux/fault-inject.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/linux/fault-inject.h b/include/linux/fault-inject.h
index 481abf530b3c..f83ab2b6cd08 100644
--- a/include/linux/fault-inject.h
+++ b/include/linux/fault-inject.h
@@ -2,9 +2,10 @@
 #ifndef _LINUX_FAULT_INJECT_H
 #define _LINUX_FAULT_INJECT_H
 
+#include <linux/types.h>
+
 #ifdef CONFIG_FAULT_INJECTION
 
-#include <linux/types.h>
 #include <linux/debugfs.h>
 #include <linux/configfs.h>
 #include <linux/ratelimit.h>
-- 
2.25.1