linux-kernel - RE: [PATCH 1/1] EDAC/igen6: Fix the issue of no error events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SJ1PR11MB6083D914A12B64369E478BA3FC03A@SJ1PR11MB6083.namprd11.prod.outlook.com>
Date:   Tue, 25 Jul 2023 15:51:24 +0000
From:   "Luck, Tony" <tony.luck@...el.com>
To:     "Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>
CC:     Borislav Petkov <bp@...en8.de>, Aristeu Rozanski <aris@...hat.com>,
        "Mauro Carvalho Chehab" <mchehab@...nel.org>,
        "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Lim, Ee Wey" <ee.wey.lim@...el.com>
Subject: RE: [PATCH 1/1] EDAC/igen6: Fix the issue of no error events

> Fix this issue by moving the pending error handler after the registration
> of the error handler, ensuring that no pending errors are left unhandled.

Do you think drivers/edac/e7xxx_edac.c has the same issue?

491
492         /* clear any pending errors, or initial state bits */
493         e7xxx_get_error_info(mci, &discard);
494
495         /* Here we assume that we will never see multiple instances of this
496          * type of memory controller.  The ID is therefore hardcoded to 0.
497          */
498         if (edac_mc_add_mc(mci)) {
499                 edac_dbg(3, "failed edac_mc_add_mc()\n");
500                 goto fail1;
501         }
502
503         /* allocating generic PCI control info */
504         e7xxx_pci = edac_pci_create_generic_ctl(&pdev->dev, EDAC_MOD_STR);

Though it might be hard to find such an old system to test.

-Tony