[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230725024553.bqwoyz4ywqx6fypb@moria.home.lan>
Date: Mon, 24 Jul 2023 22:45:53 -0400
From: Kent Overstreet <kent.overstreet@...ux.dev>
To: Christoph Hellwig <hch@...radead.org>
Cc: linux-bcachefs@...r.kernel.org, linux-fsdevel@...r.kernel.org,
linux-kernel@...r.kernel.org,
Kent Overstreet <kent.overstreet@...il.com>,
Jens Axboe <axboe@...nel.dk>, linux-block@...r.kernel.org
Subject: Re: [PATCH 06/20] block: Bring back zero_fill_bio_iter
On Mon, Jul 24, 2023 at 10:35:45AM -0700, Christoph Hellwig wrote:
> On Wed, Jul 12, 2023 at 05:11:01PM -0400, Kent Overstreet wrote:
> > From: Kent Overstreet <kent.overstreet@...il.com>
> >
> > This reverts 6f822e1b5d9dda3d20e87365de138046e3baa03a - this helper is
> > used by bcachefs.
> >
> > Signed-off-by: Kent Overstreet <kent.overstreet@...ux.dev>
> > Cc: Jens Axboe <axboe@...nel.dk>
> > Cc: linux-block@...r.kernel.org
> > ---
> > block/bio.c | 6 +++---
> > include/linux/bio.h | 7 ++++++-
> > 2 files changed, 9 insertions(+), 4 deletions(-)
>
> I really don't see any point in offering this in the block layer. By
> the lack of any other caller it obviously isn't such a generic and
> always used helper, but more importantly it literally is three lines
> of code to implement it.
And yet, we've had a subtle bug introduced in that code that took quite
awhile to be fixed - I'm not pro code duplication in general and I don't
think this is a good place to start.
Powered by blists - more mailing lists