linux-kernel - Re: [PATCH] mm/mprotect: fix obsolete function name in change_pte

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3af0795f-2ba8-2033-8b4e-e6fa889767aa@redhat.com>
Date:   Tue, 25 Jul 2023 17:54:49 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Miaohe Lin <linmiaohe@...wei.com>, akpm@...ux-foundation.org
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/mprotect: fix obsolete function name in
 change_pte_range()

On 23.07.23 05:31, Miaohe Lin wrote:
> Since commit 79a1971c5f14 ("mm: move the copy_one_pte() pte_present check
> into the caller"), the explanation of preserving soft-dirtiness is moved
> into copy_nonpresent_pte(). Update corresponding comment.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>
> ---
>   mm/mprotect.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/mprotect.c b/mm/mprotect.c
> index 5c3112d92466..3f36c88a238e 100644
> --- a/mm/mprotect.c
> +++ b/mm/mprotect.c
> @@ -213,7 +213,7 @@ static long change_pte_range(struct mmu_gather *tlb,
>   			} else if (is_writable_device_private_entry(entry)) {
>   				/*
>   				 * We do not preserve soft-dirtiness. See
> -				 * copy_one_pte() for explanation.
> +				 * copy_nonpresent_pte() for explanation.
>   				 */
>   				entry = make_readable_device_private_entry(
>   							swp_offset(entry));

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Cheers,

David / dhildenb