[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230725175639.GC838289@ravnborg.org>
Date: Tue, 25 Jul 2023 19:56:39 +0200
From: Sam Ravnborg <sam@...nborg.org>
To: Javier Martinez Canillas <javierm@...hat.com>
Cc: Geert Uytterhoeven <geert@...ux-m68k.org>,
Helge Deller <deller@....de>, Arnd Bergmann <arnd@...db.de>,
linux-fbdev@...r.kernel.org, dri-devel@...ts.freedesktop.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] video: logo: LOGO should depend on FB_CORE i.s.o. FB
Hi Javier,
> >> > menuconfig LOGO
> >> > bool "Bootup logo"
> >> > - depends on FB || SGI_NEWPORT_CONSOLE
> >> > + depends on FB_CORE || SGI_NEWPORT_CONSOLE
> >> > help
> >> > Enable and select frame buffer bootup logos.
> >>
> >> Should then move this option to drivers/video/fbdev/core/Kconfig ?
> >
> > No, all logo options are in their own file.
> >
>
> Yes. I meant to move drivers/video/logo/ to drivers/fbdev/core/logo and to
> source its Kconfig from drivers/fbdev/core/Kconfig, since it now depends
> on FB_CORE.
>
> But I see now that it also depends on SGI_NEWPORT_CONSOLE, so having those
> in drivers/video/logo makes sense indeed.
The SGI_NEWPORT_CONSOLE should be replaced by some ifdef in the
newport_con.c code - to do what other drivers do.
But thats for another day.
Sam
Powered by blists - more mailing lists