linux-kernel - Re: [PATCH] dt-bindings: power: fsl,scu-pd: separate out fsl,scu-pd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230725-excretory-speed-003064040657@spud>
Date:   Tue, 25 Jul 2023 19:36:51 +0100
From:   Conor Dooley <conor@...nel.org>
To:     "Peng Fan (OSS)" <peng.fan@....nxp.com>
Cc:     robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        conor+dt@...nel.org, ulf.hansson@...aro.org, shawnguo@...nel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-pm@...r.kernel.org, Peng Fan <peng.fan@....com>
Subject: Re: [PATCH] dt-bindings: power: fsl,scu-pd: separate out fsl,scu-pd

On Tue, Jul 25, 2023 at 06:29:00PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@....com>
> 
> Add an entry dedicated for fsl,scu-pd which could serve i.MX8DXL

Why not just add a soc-specific compatible for the i.MX8DXL?
The current form of this does not look right to me.

> 
> Signed-off-by: Peng Fan <peng.fan@....com>
> ---
>  .../devicetree/bindings/power/fsl,scu-pd.yaml         | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/power/fsl,scu-pd.yaml b/Documentation/devicetree/bindings/power/fsl,scu-pd.yaml
> index 407b7cfec783..3a92e4fef7ae 100644
> --- a/Documentation/devicetree/bindings/power/fsl,scu-pd.yaml
> +++ b/Documentation/devicetree/bindings/power/fsl,scu-pd.yaml
> @@ -18,11 +18,14 @@ allOf:
>  
>  properties:
>    compatible:
> -    items:
> +    oneOf:
>        - enum:
> -          - fsl,imx8qm-scu-pd
> -          - fsl,imx8qxp-scu-pd
> -      - const: fsl,scu-pd
> +          - fsl,scu-pd
> +      - items:
> +          - enum:
> +              - fsl,imx8qm-scu-pd
> +              - fsl,imx8qxp-scu-pd
> +          - const: fsl,scu-pd
>  
>    '#power-domain-cells':
>      const: 1
> -- 
> 2.37.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)