linux-kernel - Re: [PATCH v2] ARM: dts: samsung: exynos4412-midas: add USB connector and USB OTG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d04af4a2-a07b-66b7-47e1-5c90fb11fe54@linaro.org>
Date:   Tue, 25 Jul 2023 22:08:00 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Henrik Grimler <henrik@...mler.se>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        replicant@...osl.org, phone-devel@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht,
        Martin Jücker <martin.juecker@...il.com>,
        Artur Weber <aweber.kernel@...il.com>
Subject: Re: [PATCH v2] ARM: dts: samsung: exynos4412-midas: add USB connector
 and USB OTG

On 25/07/2023 21:15, Henrik Grimler wrote:
> On Sun, Jul 23, 2023 at 04:24:17PM +0200, Krzysztof Kozlowski wrote:
>> Add full description of USB-MUIC (MAX77693 MUIC) and MUIC-MHL
>> connections, along with proper USB connector and OTG mode for DWC2 USB
>> controller.
>>
>> This fixes dtc W=1 warnings:
>>
>>   Warning (graph_child_address): /i2c-mhl/hdmi-bridge@...ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary
>>
>> Cc: Marek Szyprowski <m.szyprowski@...sung.com>
>> Cc: replicant@...osl.org
>> Cc: phone-devel@...r.kernel.org
>> Cc: ~postmarketos/upstreaming@...ts.sr.ht
>> Cc: Martin Jücker <martin.juecker@...il.com>
>> Cc: Henrik Grimler <henrik@...mler.se>
>> Cc: Artur Weber <aweber.kernel@...il.com>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> Tested-by: Henrik Grimler <henrik@...mler.se>
> 
> * Peripheral mode (still) works
> * MHL somewhat works
> * OTG (still) does not work
> 
> Further details for those interested:
> 
> MHL works reliably if cable is attached before boot, but if cable is
> attached on already running device it sometimes work after detaching
> and attaching cable a few times.  On cable attach, when it does not
> work, we get:
> 
>   [  252.831734] max77693-muic max77693-muic: external connector is detached(chg_type:0x0, prev_chg_type:0x0)
>   [  253.733916] max77693-muic max77693-muic: external connector is attached(chg_type:0x1, prev_chg_type:0x1)
>   [  253.735232] max77693-muic max77693-muic: CONTROL1 : 0x09, CONTROL2 : 0x04, state : attached
>   [  254.691877] i2c i2c-15: sendbytes: NAK bailout.
>   [  254.692150] sii9234 15-0039: writebm:  TPI[0x3d] <- 0x3e
>   [  255.984336] sii9234 15-0039: RGND is not 1k
>   [  256.068970] sii9234 15-0039: RSEN_HIGH without RGND_1K
>   [  256.104457] sii9234 15-0039: discovery failed, no power for MHL?
>   [  256.118272] i2c i2c-15: sendbytes: NAK bailout.
>   [  256.118539] sii9234 15-0039: writebm:  TPI[0x3d] <- 0x3e
>   [  256.375966] sii9234 15-0039: RSEN_HIGH without RGND_1K
>   [  256.411561] sii9234 15-0039: discovery failed, no power for MHL?
> 
> while when it works:
> 
>   [  175.348307] max77693-muic max77693-muic: external connector is detached(chg_type:0x1, prev_chg_type:0x0)
>   [  175.349576] max77693-muic max77693-muic: CONTROL1 : 0x00, CONTROL2 : 0x01, state : detached
>   [  179.304373] dwc2 12480000.usb: new device is full-speed
>   [  179.305920] max77693-muic max77693-muic: external connector is detached(chg_type:0x0, prev_chg_type:0x0)
>   [  180.205735] max77693-muic max77693-muic: external connector is attached(chg_type:0x1, prev_chg_type:0x1)
>   [  180.207211] max77693-muic max77693-muic: CONTROL1 : 0x09, CONTROL2 : 0x04, state : attached
>   [  180.309727] i2c i2c-15: sendbytes: NAK bailout.
>   [  180.309996] sii9234 15-0039: writebm:  TPI[0x3d] <- 0x3e
> 
> Not sure if issue here is in muic driver or sii9234 driver.
> 
> OTG still does not seem to work, the muic driver detects (only) a
> detach when OTG cable is attached:
> 
>   max77693-muic max77693-muic: external connector is detached(chg_type:0x0, prev_chg_type:0x0)
> 
> Same happened when otg cable was attached before these hsotg changes
> as well. I suppose issue here is with max77693-muic driver.
> 

Thanks for testing. I miss here one important thing - did anything
regressed? Is MHL behaving not worse than before? OTG, as non-working,
matters less in such case.

Best regards,
Krzysztof