linux-kernel - Re: [PATCH v8.1 net-next 06/23] net/tcp: Add TCP-AO sign to outgoing packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZMAvL+9gMIozLbpB@corigine.com>
Date:   Tue, 25 Jul 2023 22:23:11 +0200
From:   Simon Horman <simon.horman@...igine.com>
To:     Dmitry Safonov <dima@...sta.com>
Cc:     David Ahern <dsahern@...nel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        linux-kernel@...r.kernel.org,
        Andy Lutomirski <luto@...capital.net>,
        Ard Biesheuvel <ardb@...nel.org>,
        Bob Gilligan <gilligan@...sta.com>,
        Dan Carpenter <error27@...il.com>,
        David Laight <David.Laight@...lab.com>,
        Dmitry Safonov <0x7f454c46@...il.com>,
        Donald Cassidy <dcassidy@...hat.com>,
        Eric Biggers <ebiggers@...nel.org>,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        Francesco Ruggeri <fruggeri05@...il.com>,
        "Gaillardetz, Dominik" <dgaillar@...na.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        Ivan Delalande <colona@...sta.com>,
        Leonard Crestez <cdleonard@...il.com>,
        Salam Noureddine <noureddine@...sta.com>,
        "Tetreault, Francois" <ftetreau@...na.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v8.1 net-next 06/23] net/tcp: Add TCP-AO sign to outgoing
 packets

On Tue, Jul 25, 2023 at 08:10:21PM +0100, Dmitry Safonov wrote:

...

> > 
> >> +		struct tcp_ao_key *rnext_key;
> >> +		struct tcp_ao_info *ao_info;
> >> +		u8 maclen;
> >>  
> >> +		if (WARN_ON_ONCE(!ao_key))
> >> +			goto out_ao;
> >> +		ao_info = rcu_dereference_check(tp->ao_info,
> >> +				lockdep_sock_is_held(&tp->inet_conn.icsk_inet.sk));
> > 
> > Checkpatch complains about indentation here.
> > 
> > Rather than point out each case in the series,
> > could I ask you to run ./scripts/checkpatch.pl --strict over the patchset?
> 
> Yeah, but then it won't fit 80 columns here. As both aren't hard
> requirements I tend to comply with 80 columns more than to indentation.
> In this particular case I'll check if it could be a helper function.
> If it won't make sense to separate it as a helper, I'll just move it to
> the same line than, breaking 80 columns limit.

Thanks, I missed the 80 column thing here.
I'd actually think that what you have is better than an extra long line.
But it's your call.

...