linux-kernel - Re: [PATCH] dpaa: avoid linking objects into multiple modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230725204042.opemku5oerpkpsqi@skbuf>
Date:   Tue, 25 Jul 2023 23:40:42 +0300
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Simon Horman <simon.horman@...igine.com>,
        Arnd Bergmann <arnd@...nel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Ioana Ciornei <ioana.ciornei@....com>,
        Russell King <linux@...linux.org.uk>,
        Robert-Ionut Alexa <robert-ionut.alexa@....com>,
        Russell King <rmk+kernel@...linux.org.uk>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Sean Anderson <sean.anderson@...o.com>,
        Josua Mayer <josua@...id-run.com>,
        Netdev <netdev@...r.kernel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dpaa: avoid linking objects into multiple modules

On Tue, Jul 25, 2023 at 10:37:07PM +0200, Arnd Bergmann wrote:
> On Tue, Jul 25, 2023, at 22:02, Simon Horman wrote:
> > On Tue, Jul 25, 2023 at 08:43:40AM +0200, Arnd Bergmann wrote:
> >> From: Arnd Bergmann <arnd@...db.de>
> >> 
> >> Each object file contains information about which module it gets linked
> >> into, so linking the same file into multiple modules now causes a warning:
> >> 
> >> scripts/Makefile.build:254: drivers/net/ethernet/freescale/dpaa2/Makefile: dpaa2-mac.o is added to multiple modules: fsl-dpaa2-eth fsl-dpaa2-switch
> >> scripts/Makefile.build:254: drivers/net/ethernet/freescale/dpaa2/Makefile: dpmac.o is added to multiple modules: fsl-dpaa2-eth fsl-dpaa2-switch
> >> 
> >> Chang the way that dpaa2 is built by moving the two common files into a
> >> separate module with exported symbols instead.
> >> 
> >> To avoid a link failure when the switch driver is built-in, but the dpio driver
> >> is a loadable module, add the same dependency in there that exists for
> >> the ethernet driver.
> >> 
> >> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> >
> > Hi Arnd,
> >
> > overall this looks good to me.
> > One thing that I noticed, and I'm not sure if we care,
> > is that an x86_64 allmodconfig now reports:
> >
> > WARNING: modpost: missing MODULE_DESCRIPTION() in 
> > drivers/net/ethernet/freescale/dpaa2/fsl-dpaa2-common.o
> 
> My mistake, I had disabled the warning in modpost.c as it was
> generating too much output while I tried to address some
> other warnings, so I missed the regression I introduced.
> 
> I'll send a v2, adding
> 
> MODULE_DESCRIPTION("DPAA2 Ethernet core library");
> 
>       Arnd

Hi Arnd,

Don't send a v2 yet, I'm writing a more detailed response.