linux-kernel - RE: [PATCH v5 net-next] net: phy: smsc: add WoL support to LAN8740/LAN8742 PHYs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BYAPR11MB3558593293C41090D57EADE4EC03A@BYAPR11MB3558.namprd11.prod.outlook.com>
Date:   Tue, 25 Jul 2023 23:51:43 +0000
From:   <Tristram.Ha@...rochip.com>
To:     <kuba@...nel.org>
CC:     <andrew@...n.ch>, <hkallweit1@...il.com>, <linux@...linux.org.uk>,
        <davem@...emloft.net>, <edumazet@...gle.com>, <pabeni@...hat.com>,
        <f.fainelli@...il.com>, <UNGLinuxDriver@...rochip.com>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v5 net-next] net: phy: smsc: add WoL support to
 LAN8740/LAN8742 PHYs

> On Thu, 20 Jul 2023 17:40:53 -0700 Tristram.Ha@...rochip.com wrote:
> > +#include <linux/inetdevice.h>
> > +#include <net/addrconf.h>
> > +#include <net/if_inet6.h>
> > +#include <net/ipv6.h>
> 
> You don't need these includes any more, right?
> 
> >  #include <linux/smscphy.h>
> >
> >  /* Vendor-specific PHY Definitions */
> 
> > +static int lan874x_set_wol(struct phy_device *phydev,
> > +                        struct ethtool_wolinfo *wol)
> > +{
> > +     struct net_device *ndev = phydev->attached_dev;
> > +     struct smsc_phy_priv *priv = phydev->priv;
> > +     u16 val, val_wucsr;
> > +     u8 data[128];
> > +     u8 datalen;
> > +     int rc;
> > +
> > +     if (wol->wolopts & WAKE_PHY)
> > +             return -EOPNOTSUPP;
> 
> You're not advertising the support for WAKE_PHY, so you don't have to
> check if it was requested. See recent commit 55b24334c0f2.

They will be removed in next update.