linux-kernel - Re: [PATCH] arm64: dts: ti: k3-am62a7-sk: Enable dual role support for Type-C port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1fed3f09-75e4-bb44-71d7-f7319f1b0c3c@ti.com>
Date:   Tue, 25 Jul 2023 09:49:04 +0530
From:   Ravi Gunasekaran <r-gunasekaran@...com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, <nm@...com>,
        <vigneshr@...com>, <kristo@...nel.org>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <rogerq@...nel.org>
Subject: Re: [PATCH] arm64: dts: ti: k3-am62a7-sk: Enable dual role support
 for Type-C port



On 7/24/2023 7:27 PM, Krzysztof Kozlowski wrote:
> On 24/07/2023 13:51, Ravi Gunasekaran wrote:
>> USB0 is interfaced with a Type-C DRP connector and is managed via a
>> USB PD controller. Add support for the Type-C port with dual data
>> and power sink role.
>>
>> Signed-off-by: Ravi Gunasekaran <r-gunasekaran@...com>
>> ---
>>  arch/arm64/boot/dts/ti/k3-am62a7-sk.dts | 33 +++++++++++++++++++++++++
>>  1 file changed, 33 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
>> index d2cca6182738..b478b794de00 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
>> @@ -226,6 +226,24 @@
>>  	pinctrl-names = "default";
>>  	pinctrl-0 = <&main_i2c0_pins_default>;
>>  	clock-frequency = <400000>;
>> +
>> +	typec_pd0:tps6598x@3f {

Thanks for reviewing the patch.

> Missing space after:

I will fix this in v2.

>
> Node names should be generic. See also an explanation and list of
> examples (not exhaustive) in DT specification:
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

Thanks for pointing to the section. I checked it and also few other node names
in the existing DTs.
TPS6598 is a USB Type C and Power Delivery Controller. So does a node name
"type-c-pd-controller" sound fine?

>
> Best regards,
> Krzysztof
>

Regards,
Ravi